Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1729)

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 1175803003: Inline instanceOf and 'as' operations; fix a bug in code emission (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: c Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_arm.cc
diff --git a/runtime/vm/flow_graph_compiler_arm.cc b/runtime/vm/flow_graph_compiler_arm.cc
index 71bb862b3234fc01261e3c04bf6f33d3507f8bc4..8c6c4113aeb9d786489c44d46ca0c3fac3a6fc2c 100644
--- a/runtime/vm/flow_graph_compiler_arm.cc
+++ b/runtime/vm/flow_graph_compiler_arm.cc
@@ -608,7 +608,7 @@ void FlowGraphCompiler::GenerateInstanceOf(intptr_t token_pos,
// time, since an uninstantiated type at compile time could be Object or
// dynamic at run time.
__ CompareImmediate(R0, reinterpret_cast<int32_t>(Object::null()));
- __ b(&is_not_instance, EQ);
+ __ b(type.IsNullType() ? &is_instance : &is_not_instance, EQ);
}
// Generate inline instanceof test.
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698