Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1392)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 1175803003: Inline instanceOf and 'as' operations; fix a bug in code emission (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: c Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 590 matching lines...) Expand 10 before | Expand all | Expand 10 after
601 // checking whether the tested instance is a Smi. 601 // checking whether the tested instance is a Smi.
602 if (type.IsInstantiated()) { 602 if (type.IsInstantiated()) {
603 // A null object is only an instance of Object and dynamic, which has 603 // A null object is only an instance of Object and dynamic, which has
604 // already been checked above (if the type is instantiated). So we can 604 // already been checked above (if the type is instantiated). So we can
605 // return false here if the instance is null (and if the type is 605 // return false here if the instance is null (and if the type is
606 // instantiated). 606 // instantiated).
607 // We can only inline this null check if the type is instantiated at compile 607 // We can only inline this null check if the type is instantiated at compile
608 // time, since an uninstantiated type at compile time could be Object or 608 // time, since an uninstantiated type at compile time could be Object or
609 // dynamic at run time. 609 // dynamic at run time.
610 __ CompareImmediate(R0, reinterpret_cast<int32_t>(Object::null())); 610 __ CompareImmediate(R0, reinterpret_cast<int32_t>(Object::null()));
611 __ b(&is_not_instance, EQ); 611 __ b(type.IsNullType() ? &is_instance : &is_not_instance, EQ);
612 } 612 }
613 613
614 // Generate inline instanceof test. 614 // Generate inline instanceof test.
615 SubtypeTestCache& test_cache = SubtypeTestCache::ZoneHandle(); 615 SubtypeTestCache& test_cache = SubtypeTestCache::ZoneHandle();
616 test_cache = GenerateInlineInstanceof(token_pos, type, 616 test_cache = GenerateInlineInstanceof(token_pos, type,
617 &is_instance, &is_not_instance); 617 &is_instance, &is_not_instance);
618 618
619 // test_cache is null if there is no fall-through. 619 // test_cache is null if there is no fall-through.
620 Label done; 620 Label done;
621 if (!test_cache.IsNull()) { 621 if (!test_cache.IsNull()) {
(...skipping 1235 matching lines...) Expand 10 before | Expand all | Expand 10 after
1857 DRegister dreg = EvenDRegisterOf(reg); 1857 DRegister dreg = EvenDRegisterOf(reg);
1858 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex)); 1858 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
1859 } 1859 }
1860 1860
1861 1861
1862 #undef __ 1862 #undef __
1863 1863
1864 } // namespace dart 1864 } // namespace dart
1865 1865
1866 #endif // defined TARGET_ARCH_ARM 1866 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698