Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 11745022: - Make Boolean 'true' and 'false' singleton VM isolate objects. (Closed)

Created:
7 years, 11 months ago by siva
Modified:
7 years, 11 months ago
Reviewers:
srdjan, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Make Boolean 'true' and 'false' singleton VM isolate objects. - Change all uses of it Committed: https://code.google.com/p/dart/source/detail?r=16623

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -345 lines) Patch
M lib/identical.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M lib/object.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M lib/regexp.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M vm/ast.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M vm/code_generator.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M vm/code_generator_test.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M vm/dart_api_message.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M vm/dart_api_message.cc View 1 6 chunks +47 lines, -45 lines 0 comments Download
M vm/dart_api_state.h View 2 chunks +2 lines, -4 lines 0 comments Download
M vm/flow_graph_builder.cc View 9 chunks +14 lines, -17 lines 0 comments Download
M vm/flow_graph_compiler.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M vm/flow_graph_compiler_ia32.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M vm/flow_graph_compiler_ia32.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M vm/flow_graph_compiler_x64.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M vm/flow_graph_compiler_x64.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M vm/flow_graph_optimizer.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M vm/handles.h View 1 chunk +1 line, -0 lines 0 comments Download
M vm/intermediate_language.cc View 1 4 chunks +6 lines, -7 lines 0 comments Download
M vm/intermediate_language_ia32.cc View 1 12 chunks +25 lines, -29 lines 0 comments Download
M vm/intermediate_language_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M vm/intermediate_language_x64.cc View 1 2 3 10 chunks +21 lines, -25 lines 0 comments Download
M vm/intrinsifier_ia32.cc View 13 chunks +18 lines, -34 lines 0 comments Download
M vm/intrinsifier_x64.cc View 13 chunks +18 lines, -34 lines 0 comments Download
M vm/object.h View 1 3 chunks +19 lines, -3 lines 0 comments Download
M vm/object.cc View 1 7 chunks +11 lines, -24 lines 0 comments Download
M vm/object_store.h View 2 chunks +0 lines, -8 lines 0 comments Download
M vm/object_store.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M vm/object_test.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M vm/parser.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M vm/scopes.h View 1 chunk +1 line, -1 line 0 comments Download
M vm/snapshot.cc View 4 chunks +18 lines, -18 lines 0 comments Download
M vm/snapshot_test.cc View 5 chunks +7 lines, -11 lines 0 comments Download
M vm/stub_code_ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M vm/stub_code_x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 11 months ago (2013-01-04 00:11:47 UTC) #1
siva
Forgot 2 files in the previous upload.
7 years, 11 months ago (2013-01-04 00:21:40 UTC) #2
srdjan
7 years, 11 months ago (2013-01-04 00:27:05 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698