Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: vm/flow_graph_compiler_ia32.cc

Issue 11745022: - Make Boolean 'true' and 'false' singleton VM isolate objects. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/flow_graph_compiler_ia32.h ('k') | vm/flow_graph_compiler_x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/flow_graph_compiler_ia32.cc
===================================================================
--- vm/flow_graph_compiler_ia32.cc (revision 16591)
+++ vm/flow_graph_compiler_ia32.cc (working copy)
@@ -61,7 +61,7 @@
Label fall_through;
__ cmpl(bool_register, raw_null);
__ j(EQUAL, &fall_through, Assembler::kNearJump);
- __ CompareObject(bool_register, bool_true());
+ __ CompareObject(bool_register, Bool::True());
__ j(EQUAL, is_true);
__ jmp(is_false);
__ Bind(&fall_through);
@@ -496,21 +496,21 @@
__ Drop(5);
if (negate_result) {
__ popl(EDX);
- __ LoadObject(EAX, bool_true());
+ __ LoadObject(EAX, Bool::True());
__ cmpl(EDX, EAX);
__ j(NOT_EQUAL, &done, Assembler::kNearJump);
- __ LoadObject(EAX, bool_false());
+ __ LoadObject(EAX, Bool::False());
} else {
__ popl(EAX);
}
__ jmp(&done, Assembler::kNearJump);
}
__ Bind(&is_not_instance);
- __ LoadObject(EAX, negate_result ? bool_true() : bool_false());
+ __ LoadObject(EAX, negate_result ? Bool::True() : Bool::False());
__ jmp(&done, Assembler::kNearJump);
__ Bind(&is_instance);
- __ LoadObject(EAX, negate_result ? bool_false() : bool_true());
+ __ LoadObject(EAX, negate_result ? Bool::False() : Bool::True());
__ Bind(&done);
__ popl(EDX); // Remove pushed instantiator type arguments.
__ popl(ECX); // Remove pushed instantiator.
@@ -1246,11 +1246,11 @@
__ cmpl(result, Address(ESP, 0 * kWordSize));
Label is_false;
__ j(NOT_EQUAL, &is_false, Assembler::kNearJump);
- __ LoadObject(result, bool_true());
+ __ LoadObject(result, Bool::True());
__ Drop(1);
__ jmp(skip_call);
__ Bind(&is_false);
- __ LoadObject(result, bool_false());
+ __ LoadObject(result, Bool::False());
__ Drop(1);
__ jmp(skip_call);
__ Bind(&fall_through);
« no previous file with comments | « vm/flow_graph_compiler_ia32.h ('k') | vm/flow_graph_compiler_x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698