Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Unified Diff: vm/code_generator_test.cc

Issue 11745022: - Make Boolean 'true' and 'false' singleton VM isolate objects. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/code_generator.cc ('k') | vm/dart_api_message.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/code_generator_test.cc
===================================================================
--- vm/code_generator_test.cc (revision 16591)
+++ vm/code_generator_test.cc (working copy)
@@ -160,24 +160,21 @@
CODEGEN_TEST_GENERATE(BoolNotCodegen, test) {
SequenceNode* node_seq = test->node_sequence();
- const Bool& bool_false = Bool::ZoneHandle(Bool::False());
- LiteralNode* b = new LiteralNode(kPos, bool_false);
+ LiteralNode* b = new LiteralNode(kPos, Bool::False());
UnaryOpNode* not_node = new UnaryOpNode(kPos, Token::kNOT, b);
node_seq->Add(new ReturnNode(kPos, not_node));
}
-CODEGEN_TEST_RUN(BoolNotCodegen, Bool::True())
+CODEGEN_TEST_RUN(BoolNotCodegen, Bool::True().raw())
CODEGEN_TEST_GENERATE(BoolAndCodegen, test) {
SequenceNode* node_seq = test->node_sequence();
- const Bool& bool_true = Bool::ZoneHandle(Bool::True());
- const Bool& bool_false = Bool::ZoneHandle(Bool::False());
- LiteralNode* a = new LiteralNode(kPos, bool_true);
- LiteralNode* b = new LiteralNode(kPos, bool_false);
+ LiteralNode* a = new LiteralNode(kPos, Bool::True());
+ LiteralNode* b = new LiteralNode(kPos, Bool::False());
BinaryOpNode* and_node = new BinaryOpNode(kPos, Token::kAND, a, b);
node_seq->Add(new ReturnNode(kPos, and_node));
}
-CODEGEN_TEST_RUN(BoolAndCodegen, Bool::False())
+CODEGEN_TEST_RUN(BoolAndCodegen, Bool::False().raw())
CODEGEN_TEST_GENERATE(BinaryOpCodegen, test) {
« no previous file with comments | « vm/code_generator.cc ('k') | vm/dart_api_message.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698