Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1173333007: Refactor some Timeline interfaces to be simpler and support streaming (Closed)

Created:
5 years, 6 months ago by Cutch
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@timeline2
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor some Timeline interfaces to be simpler and support streaming BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/f58029a0cd098a96970e44fa2ec9a89f0b920900

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -164 lines) Patch
M runtime/vm/dart.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 5 chunks +15 lines, -10 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/isolate.cc View 5 chunks +15 lines, -13 lines 0 comments Download
M runtime/vm/service_isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/timeline.h View 9 chunks +89 lines, -35 lines 0 comments Download
M runtime/vm/timeline.cc View 13 chunks +156 lines, -82 lines 0 comments Download
M runtime/vm/timeline_test.cc View 1 6 chunks +99 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 6 months ago (2015-06-16 17:21:10 UTC) #2
rmacnak
LGTM w/ nit https://codereview.chromium.org/1173333007/diff/1/runtime/vm/timeline_test.cc File runtime/vm/timeline_test.cc (right): https://codereview.chromium.org/1173333007/diff/1/runtime/vm/timeline_test.cc#newcode150 runtime/vm/timeline_test.cc:150: // Count the number of event ...
5 years, 6 months ago (2015-06-16 17:49:23 UTC) #3
Cutch
https://codereview.chromium.org/1173333007/diff/1/runtime/vm/timeline_test.cc File runtime/vm/timeline_test.cc (right): https://codereview.chromium.org/1173333007/diff/1/runtime/vm/timeline_test.cc#newcode150 runtime/vm/timeline_test.cc:150: // Count the number of event types seen. On ...
5 years, 6 months ago (2015-06-16 17:52:34 UTC) #4
Cutch
5 years, 6 months ago (2015-06-16 17:52:54 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f58029a0cd098a96970e44fa2ec9a89f0b920900 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698