Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 1173333007: Refactor some Timeline interfaces to be simpler and support streaming (Closed) Base URL: git@github.com:dart-lang/sdk.git@timeline2
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/deopt_instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl_test.cc
diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc
index 9f61190264a9a63245c1fff6ccb9729a75bd67df..e4562f7ebaabfc33dd4c087059ed48d11f1285aa 100644
--- a/runtime/vm/dart_api_impl_test.cc
+++ b/runtime/vm/dart_api_impl_test.cc
@@ -9163,9 +9163,9 @@ TEST_CASE(Timeline_Dart_TimelineDuration) {
// Add a duration event.
Dart_TimelineDuration("testDurationEvent", 0, 1);
// Check that it is in the output.
- TimelineEventBuffer* buffer = isolate->timeline_event_buffer();
+ TimelineEventRecorder* recorder = isolate->timeline_event_recorder();
JSONStream js;
- buffer->PrintJSON(&js);
+ recorder->PrintJSON(&js);
EXPECT_SUBSTRING("testDurationEvent", js.ToCString());
}
@@ -9178,9 +9178,9 @@ TEST_CASE(Timeline_Dart_TimelineInstant) {
stream->set_enabled(true);
Dart_TimelineInstant("testInstantEvent");
// Check that it is in the output.
- TimelineEventBuffer* buffer = isolate->timeline_event_buffer();
+ TimelineEventRecorder* recorder = isolate->timeline_event_recorder();
JSONStream js;
- buffer->PrintJSON(&js);
+ recorder->PrintJSON(&js);
EXPECT_SUBSTRING("testInstantEvent", js.ToCString());
}
@@ -9198,9 +9198,9 @@ TEST_CASE(Timeline_Dart_TimelineAsyncDisabled) {
// Call Dart_TimelineAsyncEnd with a negative async_id.
Dart_TimelineAsyncEnd("testAsyncEvent", async_id);
// Check that testAsync is not in the output.
- TimelineEventBuffer* buffer = isolate->timeline_event_buffer();
+ TimelineEventRecorder* recorder = isolate->timeline_event_recorder();
JSONStream js;
- buffer->PrintJSON(&js);
+ recorder->PrintJSON(&js);
EXPECT_NOTSUBSTRING("testAsyncEvent", js.ToCString());
}
@@ -9219,9 +9219,9 @@ TEST_CASE(Timeline_Dart_TimelineAsync) {
Dart_TimelineAsyncEnd("testAsyncEvent", async_id);
// Check that it is in the output.
- TimelineEventBuffer* buffer = isolate->timeline_event_buffer();
+ TimelineEventRecorder* recorder = isolate->timeline_event_recorder();
JSONStream js;
- buffer->PrintJSON(&js);
+ recorder->PrintJSON(&js);
EXPECT_SUBSTRING("testAsyncEvent", js.ToCString());
}
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/deopt_instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698