Refactor some Timeline interfaces to be simpler and support streaming

runtime/vm/isolate.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/json.h"
 #include "vm/code_observers.h"
@@ skipping 651 matching lines @@
       edge_counter_increment_size_(-1),
       compiler_stats_(NULL),
       is_service_isolate_(false),
       log_(new class Log()),
       stacktrace_(NULL),
       stack_frame_index_(-1),
       last_allocationprofile_accumulator_reset_timestamp_(0),
       last_allocationprofile_gc_timestamp_(0),
       object_id_ring_(NULL),
       trace_buffer_(NULL),
-      timeline_event_buffer_(NULL),
+      timeline_event_recorder_(NULL),
       profiler_data_(NULL),
       thread_state_(NULL),
       tag_table_(GrowableObjectArray::null()),
       current_tag_(UserTag::null()),
       default_tag_(UserTag::null()),
       deoptimized_code_array_(GrowableObjectArray::null()),
       metrics_list_head_(NULL),
       cha_(NULL),
       next_(NULL),
       pause_loop_monitor_(NULL),
@@ skipping 28 matching lines @@
   delete log_;
   log_ = NULL;
   delete object_id_ring_;
   object_id_ring_ = NULL;
   delete pause_loop_monitor_;
   pause_loop_monitor_ = NULL;
   if (compiler_stats_ != NULL) {
     delete compiler_stats_;
     compiler_stats_ = NULL;
   }
-  RemoveTimelineEventBuffer();
+  RemoveTimelineEventRecorder();
 }
 
 
 #if defined(DEBUG)
 bool Isolate::IsIsolateOf(Thread* thread) {
   return this == thread->isolate();
 }
 #endif  // DEBUG
 
 
@@ skipping 244 matching lines @@
     message_handler()->set_pause_on_start(FLAG_pause_isolates_on_start);
     message_handler()->set_pause_on_exit(FLAG_pause_isolates_on_exit);
   }
   IsolateSpawnState* state = spawn_state();
   if (state != NULL) {
     ASSERT(this == state->isolate());
     Run();
   }
   TimelineStream* stream = GetIsolateStream();
   ASSERT(stream != NULL);
-  TimelineEvent* event = stream->RecordEvent();
+  TimelineEvent* event = stream->StartEvent();
   if (event != NULL) {
-    event->Instant(stream, "Runnable");
+    event->Instant("Runnable");
+    event->Complete();
   }
   return true;
 }
 
 
 bool Isolate::VerifyPauseCapability(const Object& capability) const {
   return !capability.IsNull() &&
       capability.IsCapability() &&
       (pause_capability() == Capability::Cast(capability).Id());
 }
@@ skipping 471 matching lines @@
     api_state()->prologue_weak_persistent_handles().VisitHandles(&visitor);
 
     if (FLAG_trace_isolates) {
       heap()->PrintSizes();
       megamorphic_cache_table()->PrintSizes();
       Symbols::DumpStats();
       OS::Print("[-] Stopping isolate:\n"
                 "\tisolate:    %s\n", name());
     }
 
-    if ((timeline_event_buffer_ != NULL) && (FLAG_timeline_trace_dir != NULL)) {
-      timeline_event_buffer_->WriteTo(FLAG_timeline_trace_dir);
+    if ((timeline_event_recorder_ != NULL) &&
+        (FLAG_timeline_trace_dir != NULL)) {
+      timeline_event_recorder_->WriteTo(FLAG_timeline_trace_dir);
     }
   }
 
   // TODO(5411455): For now just make sure there are no current isolates
   // as we are shutting down the isolate.
   Thread::ExitIsolate();
   Profiler::ShutdownProfilingForIsolate(this);
 }
 
 
@@ skipping 79 matching lines @@
 }
 
 
 void Isolate::VisitPrologueWeakPersistentHandles(HandleVisitor* visitor) {
   if (api_state() != NULL) {
     api_state()->VisitPrologueWeakHandles(visitor);
   }
 }
 
 
-void Isolate::SetTimelineEventBuffer(
-    TimelineEventBuffer* timeline_event_buffer) {
+void Isolate::SetTimelineEventRecorder(
+    TimelineEventRecorder* timeline_event_recorder) {
 #define ISOLATE_TIMELINE_STREAM_SET_BUFFER(name, enabled_by_default)           \
-  stream_##name##_.set_buffer(timeline_event_buffer);
+  stream_##name##_.set_recorder(timeline_event_recorder);
   ISOLATE_TIMELINE_STREAM_LIST(ISOLATE_TIMELINE_STREAM_SET_BUFFER)
 #undef ISOLATE_TIMELINE_STREAM_SET_BUFFER
-  timeline_event_buffer_ = timeline_event_buffer;
+  timeline_event_recorder_ = timeline_event_recorder;
 }
 
-void Isolate::RemoveTimelineEventBuffer() {
-  SetTimelineEventBuffer(NULL);
-  delete timeline_event_buffer_;
+void Isolate::RemoveTimelineEventRecorder() {
+  SetTimelineEventRecorder(NULL);
+  delete timeline_event_recorder_;
 }
 
 
 void Isolate::PrintJSON(JSONStream* stream, bool ref) {
   JSONObject jsobj(stream);
   jsobj.AddProperty("type", (ref ? "@Isolate" : "Isolate"));
   jsobj.AddFixedServiceId("isolates/%" Pd "",
                           static_cast<intptr_t>(main_port()));
 
   jsobj.AddProperty("name", debugger_name());
@@ skipping 471 matching lines @@
                            serialized_message_, serialized_message_len_);
 }
 
 
 void IsolateSpawnState::Cleanup() {
   SwitchIsolateScope switch_scope(I);
   Dart::ShutdownIsolate();
 }
 
 }  // namespace dart