Issue 1172803002: Emit a failing error code for failing validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1172803002: Emit a failing error code for failing validation. (Closed)

Created:
5 years, 6 months ago by nweiz

Modified:
5 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Emit a failing error code for failing validation. As per #1283, this makes it easier to script pub, since it's now programattically clear whether publishing went through (or, if using --dry-run, whether validation succeeded). Closes #1283 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/23ceeceb1085d469cb46c8ae92df7acc1fc1f4d7

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -61 lines)			Patch
M	lib/src/command/lish.dart	View	6 chunks	+59 lines, -54 lines	0 comments	Download
M	test/lish/force_does_not_publish_if_there_are_errors_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/lish/package_validation_has_a_warning_and_is_canceled_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/lish/package_validation_has_an_error_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/lish/preview_package_validation_has_a_warning_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/lish/server_arg_overrides_publish_to_url_test.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	test/lish/uses_publish_to_url_test.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 6 months ago (2015-06-10 21:03:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
23ceeceb1085d469cb46c8ae92df7acc1fc1f4d7 (presubmit successful).