test/lish/package_validation_has_a_warning_and_is_canceled_test.dart - Issue 1172803002: Emit a failing error code for failing validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/lish/package_validation_has_a_warning_and_is_canceled_test.dart

Issue 1172803002: Emit a failing error code for failing validation. (Closed) Base URL: git@github.com:dart-lang/pub.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/lish/force_does_not_publish_if_there_are_errors_test.dart ('k') | test/lish/package_validation_has_an_error_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/lish/package_validation_has_a_warning_and_is_canceled_test.dart

diff --git a/test/lish/package_validation_has_a_warning_and_is_canceled_test.dart b/test/lish/package_validation_has_a_warning_and_is_canceled_test.dart

index b0454e19bf04f90b9f9e4b61f7d422bbb9dc420f..f0713d414e7747ac39b5dffe869b0c9fd16fcdd4 100644

--- a/test/lish/package_validation_has_a_warning_and_is_canceled_test.dart

+++ b/test/lish/package_validation_has_a_warning_and_is_canceled_test.dart

@@ -23,7 +23,7 @@ main() {

var pub = startPublish(server);

pub.writeLine("n");

- pub.shouldExit(exit_codes.SUCCESS);

+ pub.shouldExit(exit_codes.DATA);

pub.stderr.expect(consumeThrough("Package upload canceled."));

});

}