test/lish/preview_package_validation_has_a_warning_test.dart - Issue 1172803002: Emit a failing error code for failing validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/lish/preview_package_validation_has_a_warning_test.dart

Issue 1172803002: Emit a failing error code for failing validation. (Closed) Base URL: git@github.com:dart-lang/pub.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/lish/preview_package_validation_has_a_warning_test.dart

diff --git a/test/lish/preview_package_validation_has_a_warning_test.dart b/test/lish/preview_package_validation_has_a_warning_test.dart

index 5f80d9d9cfee65c854a4d183e47fd86e2e697ffd..5d19cfdb459da5eaf2632d6b6d18e70a2f4e6d0c 100644

--- a/test/lish/preview_package_validation_has_a_warning_test.dart

+++ b/test/lish/preview_package_validation_has_a_warning_test.dart

@@ -22,7 +22,7 @@ main() {

var server = new ScheduledServer();

var pub = startPublish(server, args: ['--dry-run']);

- pub.shouldExit(exit_codes.SUCCESS);

+ pub.shouldExit(exit_codes.DATA);

pub.stderr.expect(consumeThrough('Suggestions:'));

pub.stderr.expect(emitsLines(

'* Author "Natalie Weizenbaum" in pubspec.yaml should have an email '