Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1170673002: Begin to compute constant expressions in resolution. (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Begin to compute constant expressions in resolution. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/4db19f34516dae5d75b3da31686b38bba28a2f7d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix BinaryConstantExpression.getKnownType #

Unified diffs Side-by-side diffs Delta from patch set Stats (+762 lines, -204 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +39 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 21 chunks +120 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/core_types.dart View 2 chunks +18 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 59 chunks +433 lines, -150 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_result.dart View 1 chunk +50 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 8 chunks +75 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Johnni Winther
5 years, 6 months ago (2015-06-07 11:15:15 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1170673002/diff/1/pkg/compiler/lib/src/constants/expressions.dart File pkg/compiler/lib/src/constants/expressions.dart (right): https://codereview.chromium.org/1170673002/diff/1/pkg/compiler/lib/src/constants/expressions.dart#newcode906 pkg/compiler/lib/src/constants/expressions.dart:906: case BinaryOperatorKind.MOD: This is not true - at ...
5 years, 6 months ago (2015-06-08 09:25:24 UTC) #3
Johnni Winther
PTAL @ the last patch https://codereview.chromium.org/1170673002/diff/1/pkg/compiler/lib/src/constants/expressions.dart File pkg/compiler/lib/src/constants/expressions.dart (right): https://codereview.chromium.org/1170673002/diff/1/pkg/compiler/lib/src/constants/expressions.dart#newcode906 pkg/compiler/lib/src/constants/expressions.dart:906: case BinaryOperatorKind.MOD: On 2015/06/08 ...
5 years, 6 months ago (2015-06-08 12:18:13 UTC) #4
karlklose
Patch set 2 LGTM.
5 years, 6 months ago (2015-06-08 12:32:46 UTC) #5
Johnni Winther
5 years, 6 months ago (2015-06-08 12:42:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4db19f34516dae5d75b3da31686b38bba28a2f7d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698