pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart - Issue 1170673002: Begin to compute constant expressions in resolution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

Issue 1170673002: Begin to compute constant expressions in resolution. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fix BinaryConstantExpression.getKnownType Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

diff --git a/pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart b/pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

index d6fdc1b154be6d64db43c4be302e8df838cfefeb..57ae567823919c696797cb2cd53fdff523ff4560 100644

--- a/pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

+++ b/pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart

@@ -200,7 +200,7 @@ class JavaScriptConstantCompiler extends ConstantCompilerBase

TreeElements definitions,

{bool isConst: true}) {

ConstantExpression constant = nodeConstantMap[node];

- if (constant != null) {

+ if (constant != null && getConstantValue(constant) != null) {

return constant;

}

constant =