pkg/compiler/lib/src/constants/values.dart - Issue 1170673002: Begin to compute constant expressions in resolution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/constants/values.dart

Issue 1170673002: Begin to compute constant expressions in resolution. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fix BinaryConstantExpression.getKnownType Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/constants/values.dart

diff --git a/pkg/compiler/lib/src/constants/values.dart b/pkg/compiler/lib/src/constants/values.dart

index e40a6b838ac1dea110fc78cdacc932f3dbfa99e5..69c89cf06d5d84e7d2796969f6089a9551c8efe1 100644

--- a/pkg/compiler/lib/src/constants/values.dart

+++ b/pkg/compiler/lib/src/constants/values.dart

@@ -639,6 +639,7 @@ class ConstructedConstantValue extends ObjectConstantValue {

hashCode = Hashing.mapHash(fields, Hashing.objectHash(type)),

super(type) {

assert(type != null);

+ assert(!fields.containsValue(null));

}

bool get isConstructedObject => true;