Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1162133002: Introduce Instance.kind. (Closed)

Created:
5 years, 6 months ago by turnidge
Modified:
5 years, 6 months ago
Reviewers:
Cutch, rmacnak
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce Instance.kind. Use this instead of subclassing Instance in the service protocol. Revise many instance property names. BUG= R=johnmccutchan@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/8adf7de6d17c1f5a9dcd2b6077dc9223a3138475

Patch Set 1 #

Patch Set 2 : pre code review #

Patch Set 3 : again #

Total comments: 1

Patch Set 4 : regis feedback #

Patch Set 5 : regis feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -294 lines) Patch
M runtime/observatory/lib/src/elements/class_view.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/error_ref.html View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_ref.dart View 1 chunk +8 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 7 chunks +41 lines, -59 lines 0 comments Download
M runtime/observatory/tests/service/get_object_rpc_test.dart View 7 chunks +13 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/get_retained_size_rpc_test.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/json_test.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 22 chunks +44 lines, -36 lines 0 comments Download
M runtime/vm/object_test.cc View 13 chunks +48 lines, -18 lines 0 comments Download
M runtime/vm/report_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 3 4 12 chunks +222 lines, -147 lines 0 comments Download
M runtime/vm/service_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 6 months ago (2015-05-29 18:29:06 UTC) #2
Cutch
LGTM with one suggestion https://codereview.chromium.org/1162133002/diff/40001/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1162133002/diff/40001/runtime/vm/service/service.md#newcode1290 runtime/vm/service/service.md:1290: @Instance propertyKey [optional]; I wonder ...
5 years, 6 months ago (2015-05-29 19:34:14 UTC) #3
rmacnak
lgtm
5 years, 6 months ago (2015-05-29 19:49:05 UTC) #4
turnidge
5 years, 6 months ago (2015-05-29 20:02:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
8adf7de6d17c1f5a9dcd2b6077dc9223a3138475 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698