Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: runtime/observatory/tests/service/get_retained_size_rpc_test.dart

Issue 1162133002: Introduce Instance.kind. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: regis feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/get_object_rpc_test.dart ('k') | runtime/vm/json_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/get_retained_size_rpc_test.dart
diff --git a/runtime/observatory/tests/service/get_retained_size_rpc_test.dart b/runtime/observatory/tests/service/get_retained_size_rpc_test.dart
index 9311ccf4af0aa0ceb5eb933c02d61bcadbd3021c..93740f3359ea1189c63e2b453e91c0a63ced96a2 100644
--- a/runtime/observatory/tests/service/get_retained_size_rpc_test.dart
+++ b/runtime/observatory/tests/service/get_retained_size_rpc_test.dart
@@ -35,7 +35,8 @@ var tests = [
'targetId': evalResult['id'],
};
var result = await isolate.invokeRpcNoUpgrade('_getRetainedSize', params);
- expect(result['type'], equals('@int'));
+ expect(result['type'], equals('@Instance'));
+ expect(result['kind'], equals('Int'));
int value1 = int.parse(result['valueAsString']);
expect(value1, isPositive);
@@ -46,7 +47,8 @@ var tests = [
'targetId': evalResult['id'],
};
result = await isolate.invokeRpcNoUpgrade('_getRetainedSize', params);
- expect(result['type'], equals('@int'));
+ expect(result['type'], equals('@Instance'));
+ expect(result['kind'], equals('Int'));
int value2 = int.parse(result['valueAsString']);
expect(value2, isPositive);
@@ -58,7 +60,8 @@ var tests = [
'targetId': evalResult['class']['id'],
};
result = await isolate.invokeRpcNoUpgrade('_getRetainedSize', params);
- expect(result['type'], equals('@int'));
+ expect(result['type'], equals('@Instance'));
+ expect(result['kind'], equals('Int'));
int value3 = int.parse(result['valueAsString']);
expect(value3, isPositive);
expect(value3, equals(value2));
« no previous file with comments | « runtime/observatory/tests/service/get_object_rpc_test.dart ('k') | runtime/vm/json_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698