Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: runtime/vm/report_test.cc

Issue 1162133002: Introduce Instance.kind. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: regis feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/report_test.cc
diff --git a/runtime/vm/report_test.cc b/runtime/vm/report_test.cc
index 4d99e01f5c7ce1ac0a49417820a45881e9ac0195..24a182594a2c9528072b1494a8b2b36caa631955 100644
--- a/runtime/vm/report_test.cc
+++ b/runtime/vm/report_test.cc
@@ -33,7 +33,7 @@ TEST_CASE(TraceJSWarning) {
"\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
"\"uri\":\"Plug\","
"\"_kind\":\"script\"},\"tokenPos\":0,"
- "\"message\":{\"type\":\"@String\"",
+ "\"message\":{\"type\":\"@Instance\"",
js.ToCString());
// Skip private _OneByteString.
EXPECT_SUBSTRING("\"valueAsString\":\"High Voltage\"",
@@ -51,7 +51,7 @@ TEST_CASE(TraceJSWarning) {
"\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
"\"uri\":\"Plug\","
"\"_kind\":\"script\"},\"tokenPos\":0,"
- "\"message\":{\"type\":\"@String\"",
+ "\"message\":{\"type\":\"@Instance\"",
trace_buffer->At(0)->message);
// Skip private _OneByteString.
EXPECT_SUBSTRING("\"valueAsString\":\"High Voltage\"",
@@ -62,7 +62,7 @@ TEST_CASE(TraceJSWarning) {
"\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
"\"uri\":\"Plug\","
"\"_kind\":\"script\"},\"tokenPos\":1,"
- "\"message\":{\"type\":\"@String\"",
+ "\"message\":{\"type\":\"@Instance\"",
trace_buffer->At(1)->message);
// Skip private _OneByteString.
EXPECT_SUBSTRING("\"valueAsString\":\"Low Voltage\"",
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698