Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1160873002: Sundry service protocol cleanups before version 1.0. (Closed)

Created:
5 years, 7 months ago by turnidge
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Sundry service protocol cleanups before version 1.0. Frame.depth -> Frame.index Message.depth -> Message.index Remove Message.type Message.priority becomes private frame -> frameIndex for evaluateInFrame Class.finalized, Class.implemented, Class.patch Class.allocationStats become private Instance.nativeFields becomes private Field.value moves out of "ref" into full object Field.value -> Field.staticValue Move Function.static, Function.const to "ref" Make Script.kind private in docs Make Function.kind private BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/563083696cb9ff3ff1faa0615832f146c7a651c9

Patch Set 1 #

Patch Set 2 : pre commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -224 lines) Patch
M runtime/observatory/lib/src/elements/class_view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.html View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 8 chunks +11 lines, -13 lines 0 comments Download
M runtime/observatory/tests/service/break_on_activation_test.dart View 3 chunks +22 lines, -15 lines 0 comments Download
M runtime/observatory/tests/service/contexts_test.dart View 4 chunks +52 lines, -44 lines 0 comments Download
M runtime/observatory/tests/service/dominator_tree_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/get_object_rpc_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/get_stack_rpc_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/graph_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/inbound_references_test.dart View 1 chunk +22 lines, -22 lines 0 comments Download
M runtime/observatory/tests/service/mirror_references_test.dart View 1 chunk +11 lines, -10 lines 0 comments Download
M runtime/observatory/tests/service/string_escaping_test.dart View 1 chunk +10 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/weak_properties_test.dart View 1 chunk +17 lines, -15 lines 0 comments Download
M runtime/vm/message.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 6 chunks +13 lines, -13 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M runtime/vm/service/service.md View 9 chunks +12 lines, -48 lines 0 comments Download
M runtime/vm/service_event.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 7 months ago (2015-05-27 20:28:52 UTC) #2
rmacnak
LGTM
5 years, 7 months ago (2015-05-27 20:49:43 UTC) #3
turnidge
5 years, 6 months ago (2015-05-28 16:31:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
563083696cb9ff3ff1faa0615832f146c7a651c9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698