Sundry service protocol cleanups before version 1.0.

runtime/observatory/tests/service/break_on_activation_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override
 
 import 'package:observatory/service_io.dart';
 import 'package:unittest/unittest.dart';
 import 'test_helper.dart';
 import 'dart:async';
 
@@ skipping 46 matching lines @@
 
   var subscription;
   subscription = isolate.vm.events.stream.listen((ServiceEvent event) {
     if (event.eventType == ServiceEvent.kPauseBreakpoint) {
       print("Hit breakpoint ${event.breakpoint}");
       breaksHit++;
       isolate.resume();
     }
   });
 
-  valueOfField(String name) {
-    return rootLib.variables.singleWhere((v) => v.name == name).value;
+  valueOfField(String name) async {
+    var field = rootLib.variables.singleWhere((v) => v.name == name);
+    await field.load();
+    return field.staticValue;
+
   }
-  var r1Ref = valueOfField('r1');
-  var r2Ref = valueOfField('r2');
-  var r3Ref = valueOfField('r3');
+  var r1Ref = await valueOfField('r1');
+  var r2Ref = await valueOfField('r2');
+  var r3Ref = await valueOfField('r3');
 
   var bpt1 = await isolate.addBreakOnActivation(r1Ref);
   print("Added breakpoint $bpt1");
   expect(bpt1 is Breakpoint, isTrue);
   expect(breaksHit, equals(0));
   print("testeeDo()");
   var res = await rootLib.evaluate("testeeDo()");
   expect(res is Instance, isTrue); // Not error.
   expect(breaksHit, equals(1));
 
@@ skipping 14 matching lines @@
 
   var subscription;
   subscription = isolate.vm.events.stream.listen((ServiceEvent event) {
     if (event.eventType == ServiceEvent.kPauseBreakpoint) {
       print("Hit breakpoint ${event.breakpoint}");
       breaksHit++;
       isolate.resume();
     }
   });
 
-  valueOfField(String name) {
-    return rootLib.variables.singleWhere((v) => v.name == name).value;
+  valueOfField(String name) async {
+    var field = rootLib.variables.singleWhere((v) => v.name == name);
+    await field.load();
+    return field.staticValue;
   }
-  var r1Ref = valueOfField('r1_named');
-  var r2Ref = valueOfField('r2_named');
-  var r3Ref = valueOfField('r3_named');
+  var r1Ref = await valueOfField('r1_named');
+  var r2Ref = await valueOfField('r2_named');
+  var r3Ref = await valueOfField('r3_named');
 
   var bpt1 = await isolate.addBreakOnActivation(r1Ref);
   print("Added breakpoint $bpt1");
   expect(bpt1 is Breakpoint, isTrue);
   expect(breaksHit, equals(0));
   print("testeeDoNamed()");
   var res = await rootLib.evaluate("testeeDoNamed()");
   expect(res is Instance, isTrue); // Not error.
   expect(breaksHit, equals(1));
 
@@ skipping 14 matching lines @@
 
   var subscription;
   subscription = isolate.vm.events.stream.listen((ServiceEvent event) {
     if (event.eventType == ServiceEvent.kPauseBreakpoint) {
       print("Hit breakpoint ${event.breakpoint}");
       breaksHit++;
       isolate.resume();
     }
   });
 
-  valueOfField(String name) {
-    return rootLib.variables.singleWhere((v) => v.name == name).value;
+  valueOfField(String name) async {
+    var field = rootLib.variables.singleWhere((v) => v.name == name);
+    await field.load();
+    return field.staticValue;
   }
-  var r1Ref = valueOfField('r1');
-  var r2Ref = valueOfField('r2');
-  var r3Ref = valueOfField('r3');
+  var r1Ref = await valueOfField('r1');
+  var r2Ref = await valueOfField('r2');
+  var r3Ref = await valueOfField('r3');
 
   var bpt1 = await isolate.addBreakOnActivation(r1Ref);
   print("Added breakpoint $bpt1");
   expect(bpt1 is Breakpoint, isTrue);
   expect(breaksHit, equals(0));
   print("testeeDo()");
   var res = await rootLib.evaluate("testeeDo()");
   expect(res is Instance, isTrue); // Not error.
   expect(breaksHit, equals(1));
 
@@ skipping 19 matching lines @@
   res = await rootLib.evaluate("testeeDo()");
   expect(res is Instance, isTrue); // Not error.
   expect(breaksHit, equals(4));
 
   await subscription.cancel();
 },
 
 ];
 
 main(args) => runIsolateTests(args, tests, testeeBefore: testeeSetup);