Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2140)

Unified Diff: runtime/observatory/tests/service/mirror_references_test.dart

Issue 1160873002: Sundry service protocol cleanups before version 1.0. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: pre commit Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/mirror_references_test.dart
diff --git a/runtime/observatory/tests/service/mirror_references_test.dart b/runtime/observatory/tests/service/mirror_references_test.dart
index 444631635b02f1e54638d6dce500189cddd1d6d0..28a15c0fcd52040d11bbd5e93c3f2600dca3f254 100644
--- a/runtime/observatory/tests/service/mirror_references_test.dart
+++ b/runtime/observatory/tests/service/mirror_references_test.dart
@@ -25,22 +25,23 @@ void script() {
var tests = [
-(Isolate isolate) =>
- isolate.rootLibrary.load().then((Library lib) {
+ (Isolate isolate) async {
+ var lib = await isolate.rootLibrary.load();
Field fooField = lib.variables.singleWhere((v) => v.name == 'foo');
- Instance foo = fooField.value;
+ await fooField.load();
+ Instance foo = fooField.staticValue;
Field refField = lib.variables.singleWhere((v) => v.name == 'ref');
- Instance ref = refField.value;
+ await refField.load();
+ Instance ref = refField.staticValue;
expect(foo.isMirrorReference, isFalse);
expect(ref.isMirrorReference, isTrue);
expect(ref.referent, isNull);
- return ref.load().then((Instance loadedRef) {
- expect(loadedRef.referent, isNotNull);
- expect(loadedRef.referent.name, equals('Foo'));
- expect(loadedRef.referent, equals(foo.clazz));
- });
- }),
+ var loadedRef = await ref.load();
+ expect(loadedRef.referent, isNotNull);
+ expect(loadedRef.referent.name, equals('Foo'));
+ expect(loadedRef.referent, equals(foo.clazz));
+ },
];

Powered by Google App Engine
This is Rietveld 408576698