Issue 11590018: Avoid known native field names when minifying method names.

Issue 11590018: Avoid known native field names when minifying method names. (Closed)

Created:
8 years ago by erikcorry

Modified:
8 years ago

Reviewers:
ahe, ngeoffray

CC:
reviews_dartlang.org, ngeoffray, floitsch, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid known native field names when minifying method names. R=ahe@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16248

Patch Set 1 #

Total comments: 5

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -3 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart	View	2 chunks	+12 lines, -1 line	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/js_names.dart	View	2 chunks	+12 lines, -0 lines	4 comments	Download
A	tests/compiler/dart2js_native/native_class_fields_2_test.dart	View	1 chunk	+111 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM https://codereview.chromium.org/11590018/diff/1/sdk/lib/_internal/compiler/implementation/ssa/js_names.dart File sdk/lib/_internal/compiler/implementation/ssa/js_names.dart (right): https://codereview.chromium.org/11590018/diff/1/sdk/lib/_internal/compiler/implementation/ssa/js_names.dart#newcode158 sdk/lib/_internal/compiler/implementation/ssa/js_names.dart:158: Remove extra line. https://codereview.chromium.org/11590018/diff/1/sdk/lib/_internal/compiler/implementation/ssa/js_names.dart#newcode173 sdk/lib/_internal/compiler/implementation/ssa/js_names.dart:173: // TODO(sra): We ...

8 years ago (2012-12-17 16:23:25 UTC) #2

ngeoffray

8 years ago (2012-12-18 12:34:03 UTC) #3

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/11590018/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart
(right):

https://codereview.chromium.org/11590018/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart:39: if
(name.length < 3) {
What does this mean? Why 3?

https://codereview.chromium.org/11590018/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/js_names.dart (right):

https://codereview.chromium.org/11590018/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/js_names.dart:175: const names =
const <String>["x", "y", "z"];
What are those names in the DOM? Is this CL fixing issue 7396?

https://codereview.chromium.org/11590018/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/js_names.dart:176:
_reservedNativeProperties = new Set<String>();
You can use new Set<String>.from(names).

Expand Messages | Collapse Messages