Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

Issue 11590018: Avoid known native field names when minifying method names. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
index ba55f775f7b5ca63d6314ac7740a4fc46884b006..c55ed3815fe6286aa59de14301c5d947a0975952 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
@@ -31,8 +31,8 @@ class Namer implements ClosureNamer {
final Map<String, LibraryElement> shortPrivateNameOwners;
final Set<String> usedGlobalNames;
final Set<String> usedInstanceNames;
- final Map<String, String> instanceNameMap;
final Map<String, String> globalNameMap;
+ final Map<String, String> instanceNameMap;
final Map<String, int> popularNameCounters;
/**
@@ -235,7 +235,7 @@ class Namer implements ClosureNamer {
// Check for following situation: Native field ${fieldElement.name} has
// fixed JSName ${fieldElement.nativeName()}, but a subclass shadows this
// name. We normally handle that by renaming the superclass field, but we
- // can't do that because native fields have fixed JSNames. In practice
+ // can't do that because native fields have fixed JsNames. In practice
// this can't happen because we can't inherit from native classes.
assert (!fieldElement.hasFixedBackendName());

Powered by Google App Engine
This is Rietveld 408576698