Avoid known native field names when minifying method names.

sdk/lib/_internal/compiler/implementation/ssa/js_names.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class JsNames {
   static const javaScriptKeywords = const <String>[
     // These are current keywords
     "break", "delete", "function", "return", "typeof", "case", "do", "if",
@@ skipping 137 matching lines @@
     // Identifiers used by JsStackEmulator; later set to obfuscatable
     "\$stack", "\$stackDepth", "\$location",
 
     // TODO: prove why this is necessary or remove it
     "call"
   ];
 
   static const reservedPropertySymbols =
       const <String>["__PROTO__", "prototype", "constructor"];
 
+

[ahe, 2012/12/17 16:23:25]

Remove extra line.

   static Set<String> _reserved;
+  static Set<String> _reservedNativeProperties;
 
   static Set<String> get reserved {
     if (_reserved == null) {
       _reserved = new Set<String>();
       _reserved.addAll(reservedPropertySymbols);
       _reserved.addAll(reservedGlobalSymbols);
       _reserved.addAll(javaScriptKeywords);
     }
     return _reserved;
   }
 
+  static Set<String> get reservedNativeProperties {
+  // TODO(sra): We need a complete list from the DOM.

[ahe, 2012/12/17 16:23:25]

Add two spaces of indentation.

+    if (_reservedNativeProperties == null) {
+      const names = const <String>["x", "y", "z"];

[ngeoffray, 2012/12/18 12:34:03]

What are those names in the DOM? Is this CL fixing issue 7396?

+      _reservedNativeProperties = new Set<String>();

[ngeoffray, 2012/12/18 12:34:03]

You can use new Set<String>.from(names).

+      _reservedNativeProperties.addAll(names);
+    }
+    return _reservedNativeProperties;
+  }
+
   // TODO(ngeoffray): only the namer should call this method.
   // Eventually move it there.
   /*
    * Returns a name that does not clash with reserved JS keywords,
    * and also ensures it won't clash with other identifiers.
    */
   static String getValid(String name) {
     if (reserved.contains(name)) {
       name = '$name\$';
       assert(!reserved.contains(name));
     } else if (name.contains(r'$')) {
       name = name.replaceAll(r'$', r'$$');
     }
     return name;
   }
 }