Issue 1158193008: Eliminate Modifier.TYPEDEF and deprecate ClassElement.isTypedef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1158193008: Eliminate Modifier.TYPEDEF and deprecate ClassElement.isTypedef. (Closed)

Created:
5 years, 6 months ago by Paul Berry

Modified:
5 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Eliminate Modifier.TYPEDEF and deprecate ClassElement.isTypedef. Modifier.TYPEDEF was redundant with Modifier.MIXIN_APPLICATION and ClassElement.isTypedef was redundant with ClassElement.isMixinApplication. Since Modifier.TYPEDEF was private to analyzer, it has been eliminated. Since ClassElement.isTypedef is part of the public API to analyzer, it is retained, but with a "@deprecated" annotation. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/717da6731b6bb2a4f559e09dc717bca2877ea42d

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -28 lines)			Patch
M	pkg/analysis_server/lib/src/status/element_writer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/element.dart	View	5 chunks	+6 lines, -17 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element_handle.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/error_verifier.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/testing/element_factory.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

5 years, 6 months ago (2015-06-01 21:17:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
717da6731b6bb2a4f559e09dc717bca2877ea42d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages