Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2554)

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 1158193008: Eliminate Modifier.TYPEDEF and deprecate ClassElement.isTypedef. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/testing/element_factory.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/dart.dart
diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart
index f62c3f3ca4f7c53fc7fa7b2507eaef5108696d8e..29ab152677f6b3d4d48e8e950f5474f1af1c75d5 100644
--- a/pkg/analyzer/lib/src/task/dart.dart
+++ b/pkg/analyzer/lib/src/task/dart.dart
@@ -452,7 +452,7 @@ class BuildClassConstructorsTask extends SourceBasedAnalysisTask {
//
// ClassTypeAlias
//
- if (classElement.isTypedef) {
+ if (classElement.isMixinApplication) {
List<ConstructorElement> implicitConstructors =
new List<ConstructorElement>();
void callback(ConstructorElement explicitConstructor,
@@ -476,7 +476,7 @@ class BuildClassConstructorsTask extends SourceBasedAnalysisTask {
//
// ClassDeclaration
//
- if (!classElement.isTypedef) {
+ if (!classElement.isMixinApplication) {
bool constructorFound = false;
void callback(ConstructorElement explicitConstructor,
List<DartType> parameterTypes, List<DartType> argumentTypes) {
@@ -504,7 +504,7 @@ class BuildClassConstructorsTask extends SourceBasedAnalysisTask {
Source librarySource = classElement.library.source;
DartType superType = classElement.supertype;
if (superType is InterfaceType) {
- if (classElement.isTypedef || classElement.mixins.isNotEmpty) {
+ if (classElement.isMixinApplication || classElement.mixins.isNotEmpty) {
ClassElement superElement = superType.element;
return <String, TaskInput>{
'libraryDep': LIBRARY_ELEMENT5.of(librarySource),
« no previous file with comments | « pkg/analyzer/lib/src/generated/testing/element_factory.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698