Eliminate Modifier.TYPEDEF and deprecate ClassElement.isTypedef.

pkg/analyzer/lib/src/task/dart.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.task.dart;
 
 import 'dart:collection';
 import 'dart:math' as math;
 
 import 'package:analyzer/src/context/cache.dart';
@@ skipping 434 matching lines @@
     // Shortcut for ClassElement(s) without implicit constructors.
     //
     if (superConstructors == null) {
       outputs[CONSTRUCTORS] = classElement.constructors;
       outputs[CONSTRUCTORS_ERRORS] = AnalysisError.NO_ERRORS;
       return;
     }
     //
     // ClassTypeAlias
     //
-    if (classElement.isTypedef) {
+    if (classElement.isMixinApplication) {
       List<ConstructorElement> implicitConstructors =
           new List<ConstructorElement>();
       void callback(ConstructorElement explicitConstructor,
           List<DartType> parameterTypes, List<DartType> argumentTypes) {
         implicitConstructors.add(_createImplicitContructor(classElement.type,
             explicitConstructor, parameterTypes, argumentTypes));
       }
       if (_findForwardedConstructors(classElement, superType, callback)) {
         if (implicitConstructors.isEmpty) {
           errors.add(new AnalysisError(classElement.source,
               classElement.nameOffset, classElement.name.length,
               CompileTimeErrorCode.MIXIN_HAS_NO_CONSTRUCTORS,
               [superType.element.name]));
         } else {
           classElement.constructors = implicitConstructors;
         }
       }
       outputs[CONSTRUCTORS] = classElement.constructors;
       outputs[CONSTRUCTORS_ERRORS] = errors;
     }
     //
     // ClassDeclaration
     //
-    if (!classElement.isTypedef) {
+    if (!classElement.isMixinApplication) {
       bool constructorFound = false;
       void callback(ConstructorElement explicitConstructor,
           List<DartType> parameterTypes, List<DartType> argumentTypes) {
         constructorFound = true;
       }
       if (_findForwardedConstructors(classElement, superType, callback) &&
           !constructorFound) {
         SourceRange withRange = classElement.withClauseRange;
         errors.add(new AnalysisError(classElement.source, withRange.offset,
             withRange.length, CompileTimeErrorCode.MIXIN_HAS_NO_CONSTRUCTORS,
             [superType.element.name]));
         classElement.mixinErrorsReported = true;
       }
       outputs[CONSTRUCTORS] = classElement.constructors;
       outputs[CONSTRUCTORS_ERRORS] = errors;
     }
   }
 
   /**
    * Return a map from the names of the inputs of this kind of task to the task
    * input descriptors describing those inputs for a task with the
    * given [classElement].
    */
   static Map<String, TaskInput> buildInputs(ClassElement classElement) {
     Source librarySource = classElement.library.source;
     DartType superType = classElement.supertype;
     if (superType is InterfaceType) {
-      if (classElement.isTypedef || classElement.mixins.isNotEmpty) {
+      if (classElement.isMixinApplication || classElement.mixins.isNotEmpty) {
         ClassElement superElement = superType.element;
         return <String, TaskInput>{
           'libraryDep': LIBRARY_ELEMENT5.of(librarySource),
           SUPER_CONSTRUCTORS: CONSTRUCTORS.of(superElement)
         };
       }
     }
     // No implicit constructors.
     // Depend on LIBRARY_ELEMENT5 for invalidation.
     return <String, TaskInput>{
@@ skipping 2844 matching lines @@
   @override
   bool moveNext() {
     if (_newSources.isEmpty) {
       return false;
     }
     currentTarget = _newSources.first;
     _newSources.remove(currentTarget);
     return true;
   }
 }