Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Issue 1157173005: Include 'fixedId' key when printing service ids (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 7 months ago
Reviewers:
turnidge, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -111 lines) Patch
M runtime/vm/coverage_test.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger_test.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/json_stream.h View 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/json_stream.cc View 2 chunks +23 lines, -2 lines 0 comments Download
M runtime/vm/json_test.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/metrics.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/metrics_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 31 chunks +37 lines, -40 lines 0 comments Download
M runtime/vm/object_test.cc View 1 17 chunks +36 lines, -28 lines 0 comments Download
M runtime/vm/pages.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/report_test.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M runtime/vm/scavenger.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/service/service.md View 1 6 chunks +13 lines, -12 lines 0 comments Download
M runtime/vm/service_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Cutch
5 years, 7 months ago (2015-05-26 22:34:43 UTC) #2
rmacnak
lgtm
5 years, 7 months ago (2015-05-26 23:27:17 UTC) #4
Cutch
5 years, 7 months ago (2015-05-26 23:56:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b7534facef43bb9c95e8c0be30d462a4315a1bcd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698