runtime/vm/metrics_test.cc - Issue 1157173005: Include 'fixedId' key when printing service ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/metrics_test.cc

Issue 1157173005: Include 'fixedId' key when printing service ids (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/metrics_test.cc

diff --git a/runtime/vm/metrics_test.cc b/runtime/vm/metrics_test.cc

index 69fe54578f2bb0974279e434e1072698f148b9fd..6750a41163f98bccb00eebea4c726e4044434f35 100644

--- a/runtime/vm/metrics_test.cc

+++ b/runtime/vm/metrics_test.cc

@@ -56,7 +56,7 @@ UNIT_TEST_CASE(Metric_OnDemand) {

const char* json = js.ToCString();

EXPECT_STREQ("{\"type\":\"Counter\",\"name\":\"a.b.c\",\"description\":"

"\"foobar\",\"unit\":\"byte\","

- "\"id\":\"metrics\\/native\\/a.b.c\""

+ "\"fixedId\":true,\"id\":\"metrics\\/native\\/a.b.c\""

",\"value\":99.000000}", json);

}

« no previous file with comments | « runtime/vm/metrics.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »