runtime/vm/isolate.cc - Issue 1157173005: Include 'fixedId' key when printing service ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.cc

Issue 1157173005: Include 'fixedId' key when printing service ids (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/isolate.cc

diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc

index 9b64c07e5a62417a855ed0d8cf4a3adeeb4d6df1..ec9fbd3b100df6314bb68a37bcd3e17f7d1075ea 100644

--- a/runtime/vm/isolate.cc

+++ b/runtime/vm/isolate.cc

@@ -1491,8 +1491,8 @@ void Isolate::VisitPrologueWeakPersistentHandles(HandleVisitor* visitor) {

void Isolate::PrintJSON(JSONStream* stream, bool ref) {

JSONObject jsobj(stream);

jsobj.AddProperty("type", (ref ? "@Isolate" : "Isolate"));

- jsobj.AddPropertyF("id", "isolates/%" Pd "",

- static_cast<intptr_t>(main_port()));

+ jsobj.AddFixedServiceId("isolates/%" Pd "",

+ static_cast<intptr_t>(main_port()));

jsobj.AddProperty("name", debugger_name());

jsobj.AddPropertyF("number", "%" Pd "",

« no previous file with comments | « runtime/vm/debugger_test.cc ('k') | runtime/vm/json_stream.h » ('j') | no next file with comments »