Issue 1156803003: Service protocol cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1156803003: Service protocol cleanups. (Closed)

Created:
5 years, 6 months ago by turnidge

Modified:
5 years, 6 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Service protocol cleanups. - ServiceEvent -> Event, protocol only. - Use camel-case for StepOption - Hide FlagType but make it camel-case too. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/3d02f2130925e33ea13061f9c96abaf2b47b8a33

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -40 lines)			Patch
M	runtime/observatory/lib/src/service/object.dart	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/observatory/tests/service/get_isolate_rpc_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flags.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/service.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/service/service.md	View	1	5 chunks	+6 lines, -23 lines	0 comments	Download
M	runtime/vm/service_event.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

turnidge

Hid FlagType. Made FlagType camel-case. Turns out observatory doesn't use FlagType anyways...

5 years, 6 months ago (2015-05-28 17:18:31 UTC) #4

turnidge

5 years, 6 months ago (2015-05-28 17:24:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
3d02f2130925e33ea13061f9c96abaf2b47b8a33 (presubmit successful).