Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1156803003: Service protocol cleanups. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: after code review Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/tests/service/get_isolate_rpc_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 3c2558e6f7b40030cf5f6d9a2a97e507f8e4151d..80be9053d43ae0c067bfaae093fe44e4c7ccbd28 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -234,7 +234,7 @@ abstract class ServiceObject extends Observable {
break;
}
break;
- case 'ServiceEvent':
+ case 'Event':
obj = new ServiceEvent._empty(owner);
break;
case 'Script':
@@ -441,9 +441,9 @@ abstract class VM extends ServiceObjectOwner {
if (data != null) {
map['_data'] = data;
}
- if (map['type'] != 'ServiceEvent') {
+ if (map['type'] != 'Event') {
Logger.root.severe(
- "Expected 'ServiceEvent' but found '${map['type']}'");
+ "Expected 'Event' but found '${map['type']}'");
return;
}
@@ -1225,15 +1225,15 @@ class Isolate extends ServiceObjectOwner with Coverage {
}
Future stepInto() {
- return invokeRpc('resume', {'step': 'into'});
+ return invokeRpc('resume', {'step': 'Into'});
}
Future stepOver() {
- return invokeRpc('resume', {'step': 'over'});
+ return invokeRpc('resume', {'step': 'Over'});
}
Future stepOut() {
- return invokeRpc('resume', {'step': 'out'});
+ return invokeRpc('resume', {'step': 'Out'});
}
Future setName(String newName) {
« no previous file with comments | « no previous file | runtime/observatory/tests/service/get_isolate_rpc_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698