Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: runtime/vm/flags.cc

Issue 1156803003: Service protocol cleanups. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: after code review Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/get_isolate_rpc_test.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flags.cc
diff --git a/runtime/vm/flags.cc b/runtime/vm/flags.cc
index 6aec343922c6debc509cc04280f366b427814841..b9cda6a584607ecdf86bbb25706902d2f4be5dfe 100644
--- a/runtime/vm/flags.cc
+++ b/runtime/vm/flags.cc
@@ -429,23 +429,23 @@ void Flags::PrintFlagToJSONArray(JSONArray* jsarr, const Flag* flag) {
jsflag.AddProperty("comment", flag->comment_);
switch (flag->type_) {
case Flag::kBoolean: {
- jsflag.AddProperty("flagType", "bool");
+ jsflag.AddProperty("_flagType", "Bool");
jsflag.AddProperty("valueAsString",
(*flag->bool_ptr_ ? "true" : "false"));
break;
}
case Flag::kInteger: {
- jsflag.AddProperty("flagType", "int");
+ jsflag.AddProperty("_flagType", "Int");
jsflag.AddPropertyF("valueAsString", "%d", *flag->int_ptr_);
break;
}
case Flag::kUint64: {
- jsflag.AddProperty("flagType", "uint64_t");
+ jsflag.AddProperty("_flagType", "UInt64");
jsflag.AddPropertyF("valueAsString", "%" Pu64, *flag->uint64_ptr_);
break;
}
case Flag::kString: {
- jsflag.AddProperty("flagType", "string");
+ jsflag.AddProperty("_flagType", "String");
if (flag->charp_ptr_ != NULL) {
jsflag.AddPropertyF("valueAsString", "%s", *flag->charp_ptr_);
} else {
« no previous file with comments | « runtime/observatory/tests/service/get_isolate_rpc_test.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698