Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1156143003: Refactor Isolate -> Thread in NativeArguments and exception handler jump. (Closed)

Created:
5 years, 7 months ago by koda
Modified:
5 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor Isolate -> Thread in NativeArguments and exception handler jump. Further reduces the one-to-one assumption about isolates and threads: native entries now ask the thread for its isolate, rather than the other way around. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/6542a451c38c650a5ce9323e474982384a5daf31

Patch Set 1 #

Patch Set 2 : Port to all archs. #

Total comments: 1

Patch Set 3 : Fix comment; remove unused accessor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -178 lines) Patch
M runtime/lib/integers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/isolate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/code_generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 20 chunks +26 lines, -22 lines 0 comments Download
M runtime/vm/exceptions.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/exceptions.cc View 11 chunks +27 lines, -22 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/native_arguments.h View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/native_entry.h View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/native_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 6 chunks +7 lines, -22 lines 0 comments Download
M runtime/vm/runtime_entry.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/service_isolate.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/simulator_arm.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_arm.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/simulator_arm64.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/simulator_mips.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_mips.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 8 chunks +15 lines, -16 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 11 chunks +18 lines, -18 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 8 chunks +15 lines, -16 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 8 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
koda
5 years, 7 months ago (2015-05-26 23:23:11 UTC) #2
srdjan
lgtm https://codereview.chromium.org/1156143003/diff/20001/runtime/vm/exceptions.h File runtime/vm/exceptions.h (right): https://codereview.chromium.org/1156143003/diff/20001/runtime/vm/exceptions.h#newcode75 runtime/vm/exceptions.h:75: // into dart code or allocating any code. ...
5 years, 7 months ago (2015-05-26 23:39:02 UTC) #3
koda
5 years, 7 months ago (2015-05-26 23:50:21 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
6542a451c38c650a5ce9323e474982384a5daf31 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698