runtime/vm/native_entry.h - Issue 1156143003: Refactor Isolate -> Thread in NativeArguments and exception handler jump.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/native_entry.h

Issue 1156143003: Refactor Isolate -> Thread in NativeArguments and exception handler jump. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix comment; remove unused accessor. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/native_entry.h

diff --git a/runtime/vm/native_entry.h b/runtime/vm/native_entry.h

index 3db849c54a30b04ee8463410dec01471af955296..45dd5c9fdc1bce83140d08273b11aad74fc4b38f 100644

--- a/runtime/vm/native_entry.h

+++ b/runtime/vm/native_entry.h

@@ -51,10 +51,9 @@ typedef void (*NativeFunction)(NativeArguments* arguments);

ASSERT(arguments->NativeArgCount() == argument_count); \

TRACE_NATIVE_CALL("%s", ""#name); \

{ \

- Isolate* isolate = arguments->isolate(); \

- /* TODO(koda): Pivot from Isolate to Thread in NativeArguments. */ \

- Thread* thread = isolate->mutator_thread(); \

+ Thread* thread = arguments->thread(); \

ASSERT(thread == Thread::Current()); \

+ Isolate* isolate = thread->isolate(); \

StackZone zone(isolate); \

SET_NATIVE_RETVAL(arguments, \

DN_Helper##name(isolate, \

« no previous file with comments | « runtime/vm/native_arguments.h ('k') | runtime/vm/native_entry.cc » ('j') | no next file with comments »