Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: runtime/vm/isolate.h

Issue 1156143003: Refactor Isolate -> Thread in NativeArguments and exception handler jump. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix comment; remove unused accessor. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | runtime/vm/native_arguments.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ISOLATE_H_ 5 #ifndef VM_ISOLATE_H_
6 #define VM_ISOLATE_H_ 6 #define VM_ISOLATE_H_
7 7
8 #include "include/dart_api.h" 8 #include "include/dart_api.h"
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "vm/base_isolate.h" 10 #include "vm/base_isolate.h"
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 message_notify_callback_ = value; 165 message_notify_callback_ = value;
166 } 166 }
167 167
168 // A thread that operates on this isolate and may execute Dart code. 168 // A thread that operates on this isolate and may execute Dart code.
169 // No other threads operating on this isolate may execute Dart code. 169 // No other threads operating on this isolate may execute Dart code.
170 // TODO(koda): Remove after pivoting to thread in NativeArguments. 170 // TODO(koda): Remove after pivoting to thread in NativeArguments.
171 Thread* mutator_thread() { 171 Thread* mutator_thread() {
172 DEBUG_ASSERT(mutator_thread_ == NULL || IsIsolateOf(mutator_thread_)); 172 DEBUG_ASSERT(mutator_thread_ == NULL || IsIsolateOf(mutator_thread_));
173 return mutator_thread_; 173 return mutator_thread_;
174 } 174 }
175 // TODO(koda): Remove after pivoting to thread in JumpToExceptionHandler.
176 static intptr_t mutator_thread_offset() {
177 return OFFSET_OF(Isolate, mutator_thread_);
178 }
179 #if defined(DEBUG) 175 #if defined(DEBUG)
180 bool IsIsolateOf(Thread* thread); 176 bool IsIsolateOf(Thread* thread);
181 #endif // DEBUG 177 #endif // DEBUG
182 178
183 const char* name() const { return name_; } 179 const char* name() const { return name_; }
184 const char* debugger_name() const { return debugger_name_; } 180 const char* debugger_name() const { return debugger_name_; }
185 void set_debugger_name(const char* name); 181 void set_debugger_name(const char* name);
186 182
187 // TODO(koda): Move to Thread. 183 // TODO(koda): Move to Thread.
188 class Log* Log() const; 184 class Log* Log() const;
(...skipping 778 matching lines...) Expand 10 before | Expand all | Expand 10 after
967 uint8_t* serialized_args_; 963 uint8_t* serialized_args_;
968 intptr_t serialized_args_len_; 964 intptr_t serialized_args_len_;
969 uint8_t* serialized_message_; 965 uint8_t* serialized_message_;
970 intptr_t serialized_message_len_; 966 intptr_t serialized_message_len_;
971 bool paused_; 967 bool paused_;
972 }; 968 };
973 969
974 } // namespace dart 970 } // namespace dart
975 971
976 #endif // VM_ISOLATE_H_ 972 #endif // VM_ISOLATE_H_
OLDNEW
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | runtime/vm/native_arguments.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698