Fix 56 hints in pkg/compiler

Fix 56 hints in pkg/compiler

From 258 to 202

R=johnniwinther@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/51a8f0751d5dd4fa61c2a44bb8f666df628e3922

[kevmoo, 2015-05-21 20:11:36]

kevmoo@google.com changed reviewers:
+ sigmund@google.com, sra@google.com

[kevmoo, 2015-05-21 20:11:37]

Also fix the time output in dump-info

[Siggi Cherem (dart-lang), 2015-05-22 03:20:20]

sigmund@google.com changed reviewers:
+ johnniwinther@google.com

[Siggi Cherem (dart-lang), 2015-05-22 03:20:21]

+johnniwinther: can you take a look at the question for use_unused_api.dart?

Besides the comments below, lgtm

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/scanne...
File pkg/compiler/lib/src/scanner/parser_task.dart (left):

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/scanne...
pkg/compiler/lib/src/scanner/parser_task.dart:21: } on ParserError catch (e) {
Weird - I didn't know the "catch" was optional here. Really?

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/scanne...
File pkg/compiler/lib/src/scanner/scanner_task.dart (left):

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/scanne...
pkg/compiler/lib/src/scanner/scanner_task.dart:66: } on ParserError catch (e) {
ditto

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/use_un...
File pkg/compiler/lib/src/use_unused_api.dart (left):

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/use_un...
pkg/compiler/lib/src/use_unused_api.dart:19: import
'cps_ir/cps_ir_nodes_sexpr.dart' as cps_ir_nodes_sexpr;
I think this is OK, but I'm not 100% sure about this one. This test file is used
to cover APIs that are not yet used in some parts of the compiler. I think the
test covers with code what we want to test, but I'm not sure if we also try to
keep things reachable as well.

Johnni - is it relevant for this test to keep this unused import?

[Johnni Winther, 2015-05-22 07:37:57]

LGTM w/comments.

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/dump_i...
File pkg/compiler/lib/src/dump_info.dart (right):

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/dump_i...
pkg/compiler/lib/src/dump_info.dart:559: var stopwatch = new Stopwatch();
'var' -> 'Stopwatch'

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/scanne...
File pkg/compiler/lib/src/scanner/parser_task.dart (left):

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/scanne...
pkg/compiler/lib/src/scanner/parser_task.dart:21: } on ParserError catch (e) {
On 2015/05/22 03:20:21, Siggi Cherem (dart-lang) wrote:
> Weird - I didn't know the "catch" was optional here. Really?

Neither did I nor dart2js. Leave these in and file a bug on dart2js.

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/use_un...
File pkg/compiler/lib/src/use_unused_api.dart (left):

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/use_un...
pkg/compiler/lib/src/use_unused_api.dart:19: import
'cps_ir/cps_ir_nodes_sexpr.dart' as cps_ir_nodes_sexpr;
On 2015/05/22 03:20:21, Siggi Cherem (dart-lang) wrote:
> I think this is OK, but I'm not 100% sure about this one. This test file is
used
> to cover APIs that are not yet used in some parts of the compiler. I think the
> test covers with code what we want to test, but I'm not sure if we also try to
> keep things reachable as well.
> 
> Johnni - is it relevant for this test to keep this unused import?

No, this can be removed.

[kevmoo, 2015-05-22 15:39:02]

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/dump_i...
File pkg/compiler/lib/src/dump_info.dart (right):

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/dump_i...
pkg/compiler/lib/src/dump_info.dart:559: var stopwatch = new Stopwatch();
On 2015/05/22 07:37:57, Johnni Winther wrote:
> 'var' -> 'Stopwatch'

Done.

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/scanne...
File pkg/compiler/lib/src/scanner/parser_task.dart (left):

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/scanne...
pkg/compiler/lib/src/scanner/parser_task.dart:21: } on ParserError catch (e) {
On 2015/05/22 07:37:57, Johnni Winther wrote:
> On 2015/05/22 03:20:21, Siggi Cherem (dart-lang) wrote:
> > Weird - I didn't know the "catch" was optional here. Really?
> 
> Neither did I nor dart2js. Leave these in and file a bug on dart2js.

Done

https://code.google.com/p/dart/issues/detail?id=23510

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/scanne...
File pkg/compiler/lib/src/scanner/scanner_task.dart (left):

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/scanne...
pkg/compiler/lib/src/scanner/scanner_task.dart:66: } on ParserError catch (e) {
On 2015/05/22 03:20:21, Siggi Cherem (dart-lang) wrote:
> ditto

Done.

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/use_un...
File pkg/compiler/lib/src/use_unused_api.dart (left):

https://codereview.chromium.org/1155633002/diff/1/pkg/compiler/lib/src/use_un...
pkg/compiler/lib/src/use_unused_api.dart:19: import
'cps_ir/cps_ir_nodes_sexpr.dart' as cps_ir_nodes_sexpr;
On 2015/05/22 07:37:57, Johnni Winther wrote:
> On 2015/05/22 03:20:21, Siggi Cherem (dart-lang) wrote:
> > I think this is OK, but I'm not 100% sure about this one. This test file is
> used
> > to cover APIs that are not yet used in some parts of the compiler. I think
the
> > test covers with code what we want to test, but I'm not sure if we also try
to
> > keep things reachable as well.
> > 
> > Johnni - is it relevant for this test to keep this unused import?
> 
> No, this can be removed.

Acknowledged.

[kevmoo, 2015-05-22 15:45:17]

Committed patchset #3 (id:40001) manually as
51a8f0751d5dd4fa61c2a44bb8f666df628e3922 (presubmit successful).