Fix 56 hints in pkg/compiler

pkg/compiler/lib/src/scanner/parser.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of scanner;
 
 class FormalParameterType {
   final String type;
   const FormalParameterType(this.type);
   bool get isRequired => this == REQUIRED;
@@ skipping 381 matching lines @@
     } while (optional(',', token));
     listener.endOptionalFormalParameters(parameterCount, begin, token);
     if (isNamed) {
       return expect('}', token);
     } else {
       return expect(']', token);
     }
   }
 
   Token parseTypeOpt(Token token) {
-    String value = token.stringValue;
     Token peek = peekAfterIfType(token);
     if (peek != null && (peek.isIdentifier() || optional('this', peek))) {
       return parseType(token);
     }
     listener.handleNoType(token);
     return token;
   }
 
   bool isValidTypeReference(Token token) {
     final kind = token.kind;
@@ skipping 519 matching lines @@
   ///     get foo async* { return null }
   /// results in
   ///     ['{', 'foo', 'get']
   ///
   ///
   ///     operator *(arg) => null;
   /// results in
   ///     ['(', '*', 'operator']
   ///
   Link<Token> findMemberName(Token token) {
-    Token start = token;
     Link<Token> identifiers = const Link<Token>();
 
     // `true` if 'get' has been seen.
     bool isGetter = false;
     // `true` if an identifier has been seen after 'get'.
     bool hasName = false;
 
     while (token.kind != EOF_TOKEN) {
       String value = token.stringValue;
       if (value == 'get') {
@@ skipping 202 matching lines @@
   }
 
   bool isFactoryDeclaration(Token token) {
     if (optional('external', token)) token = token.next;
     if (optional('const', token)) token = token.next;
     return optional('factory', token);
   }
 
   Token parseMember(Token token) {
     token = parseMetadataStar(token);
-    String value = token.stringValue;
     if (isFactoryDeclaration(token)) {
       return parseFactoryMethod(token);
     }
     Token start = token;
     listener.beginMember(token);
 
     Link<Token> identifiers = findMemberName(token);
     if (identifiers.isEmpty) {
       return listener.expectedDeclaration(start);
     }
@@ skipping 156 matching lines @@
     Token constKeyword = null;
     if (optional('const', token)) {
       constKeyword = token;
       token = token.next;
     }
     Token factoryKeyword = token;
     listener.beginFactoryMethod(factoryKeyword);
     token = token.next; // Skip 'factory'.
     token = parseConstructorReference(token);
     token = parseFormalParameters(token);
-    bool previousYieldIsKeyword = yieldIsKeyword;
-    bool previousAwaitIsKeyword = awaitIsKeyword;
     token = parseAsyncModifier(token);
     if (optional('=', token)) {
       token = parseRedirectingFactoryBody(token);
     } else {
       token = parseFunctionBody(token, false, externalModifier != null);
     }
     listener.endFactoryMethod(start, token);
     return token.next;
   }
 
@@ skipping 1309 matching lines @@
     }
     listener.handleContinueStatement(hasTarget, continueKeyword, token);
     return expectSemicolon(token);
   }
 
   Token parseEmptyStatement(Token token) {
     listener.handleEmptyStatement(token);
     return expectSemicolon(token);
   }
 }