pkg/compiler/lib/src/js_backend/runtime_types.dart - Issue 1155633002: Fix 56 hints in pkg/compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/runtime_types.dart

Issue 1155633002: Fix 56 hints in pkg/compiler (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/runtime_types.dart

diff --git a/pkg/compiler/lib/src/js_backend/runtime_types.dart b/pkg/compiler/lib/src/js_backend/runtime_types.dart

index cee17622ac079808fec3a2dcf3cb79acf992b6c2..2b13f034dad8861b1e94fa3daf4a0b887d1fd2b4 100644

--- a/pkg/compiler/lib/src/js_backend/runtime_types.dart

+++ b/pkg/compiler/lib/src/js_backend/runtime_types.dart

@@ -664,11 +664,9 @@ class TypeRepresentationGenerator implements DartTypeVisitor {

}

jsAst.Expression visitList(List<DartType> types, {jsAst.Expression head}) {

- int index = 0;

List<jsAst.Expression> elements = <jsAst.Expression>[];

if (head != null) {

elements.add(head);

- index++;

}

for (DartType type in types) {

jsAst.Expression element = visit(type);