Issue 1154033002: Schedule ChangeNotice results only after parse/resolve/errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1154033002: Schedule ChangeNotice results only after parse/resolve/errors. (Closed)

Created:
5 years, 7 months ago by scheglov

Modified:
5 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Schedule ChangeNotice results only after parse/resolve/errors. We have too many steps to compute all the errors. It does not worth to send them every time. This helps to save 500 ms on the analyzer project. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8bcdd16e06859e3943a2632c28dbab9f43da4778

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -17 lines)			Patch
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/task/dart_work_manager.dart	View	3 chunks	+1 line, -9 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_work_manager_test.dart	View	2 chunks	+7 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 7 months ago (2015-05-24 17:02:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8bcdd16e06859e3943a2632c28dbab9f43da4778 (presubmit successful).