Schedule ChangeNotice results only after parse/resolve/errors.

pkg/analyzer/lib/src/task/dart_work_manager.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.task.dart_work_manager;
 
 import 'dart:collection';
 
 import 'package:analyzer/src/context/cache.dart';
 import 'package:analyzer/src/generated/engine.dart'
@@ skipping 264 matching lines @@
       }
     }
     // Update notice.
     if (_isDartSource(target)) {
       bool shouldSetErrors = false;
       outputs.forEach((ResultDescriptor descriptor, value) {
         if (descriptor == PARSED_UNIT && value != null) {
           context.getNotice(target).parsedDartUnit = value;
           shouldSetErrors = true;
         }
-        if (_isErrorResult(descriptor)) {
+        if (descriptor == DART_ERRORS) {
           shouldSetErrors = true;
         }
       });
       if (shouldSetErrors) {
         AnalysisErrorInfo info = getErrors(target);
         context.getNotice(target).setErrors(info.errors, info.lineInfo);
       }
     }
     if (target is LibrarySpecificUnit) {
       Source source = target.source;
       bool shouldSetErrors = false;
       outputs.forEach((ResultDescriptor descriptor, value) {
         if (descriptor == RESOLVED_UNIT && value != null) {
           context.getNotice(source).resolvedDartUnit = value;
           shouldSetErrors = true;
         }
-        if (_isErrorResult(descriptor)) {
-          shouldSetErrors = true;
-        }
       });
       if (shouldSetErrors) {
         AnalysisErrorInfo info = getErrors(source);
         context.getNotice(source).setErrors(info.errors, info.lineInfo);
       }
     }
   }
 
   /**
    * Returns `true` if the given [result] of the given [target] needs
@@ skipping 16 matching lines @@
         if (libraries != null) {
           libraries.remove(library);
         }
       }
     }
   }
 
   static bool _isDartSource(AnalysisTarget target) {
     return target is Source && AnalysisEngine.isDartFileName(target.fullName);
   }
-
-  static bool _isErrorResult(ResultDescriptor descriptor) {
-    return _SOURCE_ERRORS.contains(descriptor) ||
-        _UNIT_ERRORS.contains(descriptor);
-  }
 }