pkg/analyzer/lib/src/generated/incremental_resolver.dart - Issue 1154033002: Schedule ChangeNotice results only after parse/resolve/errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/incremental_resolver.dart

Issue 1154033002: Schedule ChangeNotice results only after parse/resolve/errors. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/generated/incremental_resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/incremental_resolver.dart b/pkg/analyzer/lib/src/generated/incremental_resolver.dart

index 828949ae69c982e5d0df0c8efefa37c219c3ea9a..c22ec67a97c9ab6b6f71b84e0d6b6d9111fc86a5 100644

--- a/pkg/analyzer/lib/src/generated/incremental_resolver.dart

+++ b/pkg/analyzer/lib/src/generated/incremental_resolver.dart

@@ -22,7 +22,7 @@ import 'package:analyzer/src/task/dart.dart'

USED_LOCAL_ELEMENTS,

VERIFY_ERRORS;

import 'package:analyzer/task/dart.dart'

- show LibrarySpecificUnit, PARSED_UNIT, TOKEN_STREAM;

+ show DART_ERRORS, LibrarySpecificUnit, PARSED_UNIT, TOKEN_STREAM;

import 'package:analyzer/task/general.dart' show CONTENT;

import 'package:analyzer/task/model.dart' show ResultDescriptor;

@@ -1544,6 +1544,7 @@ class PoorMansIncrementalResolver {

}

void _updateEntry_NEW() {

+ _newSourceEntry.setState(DART_ERRORS, CacheState.INVALID);

// scan results

_newSourceEntry.setState(SCAN_ERRORS, CacheState.INVALID);

List<TargetedResult> scanDeps =

« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/dart_work_manager.dart » ('j') | no next file with comments »