Issue 1153253004: Issue 23389. Report error in the renamed element be invisible after rename.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153253004: Issue 23389. Report error in the renamed element be invisible after rename. (Closed)

Created:
5 years, 6 months ago by scheglov

Modified:
5 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Issue 23389. Report error in the renamed element be invisible after rename. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=23389 Committed: https://github.com/dart-lang/sdk/commit/5b44136f2a2f52d51ab07bdd3c8cf3ef774ecb29

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -5 lines)			Patch
M	pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart	View	4 chunks	+27 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart	View	3 chunks	+22 lines, -4 lines	1 comment	Download
M	pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1153253004/diff/1/pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart File pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart (right): https://codereview.chromium.org/1153253004/diff/1/pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart#newcode172 pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart:172: Future _validateWillBeInvisible() async { It's sad to see ...

5 years, 6 months ago (2015-06-01 17:32:29 UTC) #2

scheglov

5 years, 6 months ago (2015-06-01 17:41:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5b44136f2a2f52d51ab07bdd3c8cf3ef774ecb29 (presubmit successful).

Expand Messages | Collapse Messages