Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart

Issue 1153253004: Issue 23389. Report error in the renamed element be invisible after rename. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart b/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
index 6e0427fb6d36df17231dfe2ff0f0c4bdcfcf884e..229d1bef6d10254fce46a39cb652b176c758c452 100644
--- a/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
@@ -65,6 +65,26 @@ class B extends A {
assertRefactoringStatusOK(status);
}
+ test_checkFinalConditions_publicToPrivate_usedInOtherLibrary() async {
+ indexTestUnit('''
+class Test {}
+''');
+ indexUnit('/lib.dart', '''
+library my.lib;
+import 'test.dart';
+
+main() {
+ new Test();
+}
+''');
+ createRenameRefactoringAtString('Test {}');
+ // check status
+ refactoring.newName = '_NewName';
+ RefactoringStatus status = await refactoring.checkFinalConditions();
+ assertRefactoringStatus(status, RefactoringProblemSeverity.ERROR,
+ expectedMessage: "Renamed class will be invisible in 'my.lib'.");
+ }
+
test_checkFinalConditions_shadowedBy_MethodElement() async {
indexTestUnit('''
class Test {}

Powered by Google App Engine
This is Rietveld 408576698