Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

Issue 1153253004: Issue 23389. Report error in the renamed element be invisible after rename. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart b/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
index d8e2a684738573fa8e4a50f242b9d03dfc467765..e88f48990a35e1f78dbee6182ae29ae4904d6c6a 100644
--- a/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
@@ -55,6 +55,28 @@ class C extends A {
assertRefactoringStatusOK(status);
}
+ test_checkFinalConditions_publicToPrivate_usedInOtherLibrary() async {
+ indexTestUnit('''
+class A {
+ test() {}
+}
+''');
+ indexUnit('/lib.dart', '''
+library my.lib;
+import 'test.dart';
+
+main(A a) {
+ a.test();
+}
+''');
+ createRenameRefactoringAtString('test() {}');
+ // check status
+ refactoring.newName = '_newName';
+ RefactoringStatus status = await refactoring.checkFinalConditions();
+ assertRefactoringStatus(status, RefactoringProblemSeverity.ERROR,
+ expectedMessage: "Renamed method will be invisible in 'my.lib'.");
+ }
+
test_checkFinalConditions_shadowed_byLocal_inSameClass() async {
indexTestUnit('''
class A {

Powered by Google App Engine
This is Rietveld 408576698