Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1149543002: Change the pre-release range semantics. (Closed)

Created:
5 years, 7 months ago by nweiz
Modified:
5 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub_semver@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change the pre-release range semantics. This allows ">=1.2.3-dev <1.2.3" to work how it looks like it should work, as opposed to matching no versions at all. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub_semver/commit/cf3b3494af9ad40687e33780a870bbfa87a11500

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -12 lines) Patch
M CHANGELOG.md View 1 chunk +8 lines, -0 lines 0 comments Download
M README.md View 1 chunk +6 lines, -4 lines 0 comments Download
M lib/src/version_range.dart View 1 1 chunk +29 lines, -8 lines 0 comments Download
M test/version_range_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 7 months ago (2015-05-19 20:44:00 UTC) #1
Bob Nystrom
LGTM! https://codereview.chromium.org/1149543002/diff/1/lib/src/version_range.dart File lib/src/version_range.dart (right): https://codereview.chromium.org/1149543002/diff/1/lib/src/version_range.dart#newcode103 lib/src/version_range.dart:103: // Instead, we ensure that release versions will ...
5 years, 7 months ago (2015-05-20 21:48:45 UTC) #2
nweiz
Code review changes
5 years, 7 months ago (2015-05-20 23:46:49 UTC) #3
nweiz
https://codereview.chromium.org/1149543002/diff/1/lib/src/version_range.dart File lib/src/version_range.dart (right): https://codereview.chromium.org/1149543002/diff/1/lib/src/version_range.dart#newcode103 lib/src/version_range.dart:103: // Instead, we ensure that release versions will always ...
5 years, 7 months ago (2015-05-20 23:46:55 UTC) #4
nweiz
5 years, 7 months ago (2015-05-20 23:48:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cf3b3494af9ad40687e33780a870bbfa87a11500 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698