Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: test/version_range_test.dart

Issue 1149543002: Change the pre-release range semantics. (Closed) Base URL: git@github.com:dart-lang/pub_semver@master
Patch Set: Code review changes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/version_range.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/version_range_test.dart
diff --git a/test/version_range_test.dart b/test/version_range_test.dart
index ef35d802237936b7452d70e192728f31703c310b..6df6b310adf199c130e15c614295ea4964931f8a 100644
--- a/test/version_range_test.dart
+++ b/test/version_range_test.dart
@@ -105,6 +105,18 @@ main() {
new Version.parse('2.3.4')));
});
+ test('pre-release versions of non-pre-release max are included if min is a '
+ 'pre-release of the same version', () {
+ var range = new VersionRange(
+ min: new Version.parse('2.3.4-dev.0'), max: v234);
+
+ expect(range, allows(new Version.parse('2.3.4-dev.1')));
+ expect(range, doesNotAllow(
+ new Version.parse('2.3.3'),
+ new Version.parse('2.3.4-dev'),
+ new Version.parse('2.3.4')));
+ });
+
test('pre-release versions of pre-release max are included', () {
var range = new VersionRange(max: new Version.parse('2.3.4-dev.2'));
« no previous file with comments | « lib/src/version_range.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698