Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Side by Side Diff: test/version_range_test.dart

Issue 1149543002: Change the pre-release range semantics. (Closed) Base URL: git@github.com:dart-lang/pub_semver@master
Patch Set: Code review changes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/src/version_range.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library pub_semver.test.version_range_test; 5 library pub_semver.test.version_range_test;
6 6
7 import 'package:test/test.dart'; 7 import 'package:test/test.dart';
8 8
9 import 'package:pub_semver/pub_semver.dart'; 9 import 'package:pub_semver/pub_semver.dart';
10 10
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 98
99 test('pre-release versions of non-pre-release max are excluded', () { 99 test('pre-release versions of non-pre-release max are excluded', () {
100 var range = new VersionRange(max: v234); 100 var range = new VersionRange(max: v234);
101 101
102 expect(range, allows(new Version.parse('2.3.3'))); 102 expect(range, allows(new Version.parse('2.3.3')));
103 expect(range, doesNotAllow( 103 expect(range, doesNotAllow(
104 new Version.parse('2.3.4-dev'), 104 new Version.parse('2.3.4-dev'),
105 new Version.parse('2.3.4'))); 105 new Version.parse('2.3.4')));
106 }); 106 });
107 107
108 test('pre-release versions of non-pre-release max are included if min is a '
109 'pre-release of the same version', () {
110 var range = new VersionRange(
111 min: new Version.parse('2.3.4-dev.0'), max: v234);
112
113 expect(range, allows(new Version.parse('2.3.4-dev.1')));
114 expect(range, doesNotAllow(
115 new Version.parse('2.3.3'),
116 new Version.parse('2.3.4-dev'),
117 new Version.parse('2.3.4')));
118 });
119
108 test('pre-release versions of pre-release max are included', () { 120 test('pre-release versions of pre-release max are included', () {
109 var range = new VersionRange(max: new Version.parse('2.3.4-dev.2')); 121 var range = new VersionRange(max: new Version.parse('2.3.4-dev.2'));
110 122
111 expect(range, allows( 123 expect(range, allows(
112 new Version.parse('2.3.4-dev.1'))); 124 new Version.parse('2.3.4-dev.1')));
113 expect(range, doesNotAllow( 125 expect(range, doesNotAllow(
114 new Version.parse('2.3.4-dev.2'), 126 new Version.parse('2.3.4-dev.2'),
115 new Version.parse('2.3.4-dev.3'))); 127 new Version.parse('2.3.4-dev.3')));
116 }); 128 });
117 129
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 expect(result, equals(new VersionRange( 441 expect(result, equals(new VersionRange(
430 min: v003, max: v114, includeMin: true, includeMax: true))); 442 min: v003, max: v114, includeMin: true, includeMax: true)));
431 }); 443 });
432 }); 444 });
433 445
434 test('isEmpty', () { 446 test('isEmpty', () {
435 expect(new VersionRange().isEmpty, isFalse); 447 expect(new VersionRange().isEmpty, isFalse);
436 expect(new VersionRange(min: v123, max: v124).isEmpty, isFalse); 448 expect(new VersionRange(min: v123, max: v124).isEmpty, isFalse);
437 }); 449 });
438 } 450 }
OLDNEW
« no previous file with comments | « lib/src/version_range.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698