Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1146943002: Change Link to List in FunctionSignature. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -94 lines) Patch
M pkg/compiler/lib/src/dart_backend/placeholder_collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 4 chunks +9 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart View 5 chunks +17 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 2 chunks +7 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 1 chunk +6 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/util/link.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/concrete_type_inference_test.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/type_equals_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_substitution_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-05-20 11:47:04 UTC) #2
karlklose
LGTM!
5 years, 7 months ago (2015-05-20 11:51:11 UTC) #3
Johnni Winther
5 years, 7 months ago (2015-05-20 12:08:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b599de618e4abe2c5339093f8e2b5d997f8456e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698