Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1508)

Unified Diff: pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

Issue 1146943002: Change Link to List in FunctionSignature. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart
diff --git a/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart b/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart
index 5aa71debeb7f74c3ee64e8ff0c09d3ee8f0bcad7..86c95ccf26d7278e7ca0574aab25ee5e021db4a0 100644
--- a/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart
+++ b/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart
@@ -44,19 +44,15 @@ List<ParameterMirror> _parametersFromFunctionSignature(
Dart2JsDeclarationMirror owner,
FunctionSignature signature) {
var parameters = <ParameterMirror>[];
- Link<Element> link = signature.requiredParameters;
- while (!link.isEmpty) {
+ signature.requiredParameters.forEach((FormalElement parameter) {
parameters.add(new Dart2JsParameterMirror(
- owner, link.head, isOptional: false, isNamed: false));
- link = link.tail;
- }
- link = signature.optionalParameters;
+ owner, parameter, isOptional: false, isNamed: false));
+ });
bool isNamed = signature.optionalParametersAreNamed;
- while (!link.isEmpty) {
+ signature.optionalParameters.forEach((FormalElement parameter) {
parameters.add(new Dart2JsParameterMirror(
- owner, link.head, isOptional: true, isNamed: isNamed));
- link = link.tail;
- }
+ owner, parameter, isOptional: true, isNamed: isNamed));
+ });
return parameters;
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/patch_resolver.dart ('k') | pkg/compiler/lib/src/resolution/enum_creator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698