Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: pkg/compiler/lib/src/js_backend/patch_resolver.dart

Issue 1146943002: Change Link to List in FunctionSignature. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/patch_resolver.dart
diff --git a/pkg/compiler/lib/src/js_backend/patch_resolver.dart b/pkg/compiler/lib/src/js_backend/patch_resolver.dart
index 84d67cc36c45fab366ac3a2ff39f38f0a429f387..56c5203c07e81d096e4145710b4d5913aa7892d4 100644
--- a/pkg/compiler/lib/src/js_backend/patch_resolver.dart
+++ b/pkg/compiler/lib/src/js_backend/patch_resolver.dart
@@ -34,11 +34,13 @@ class PatchResolverTask extends CompilerTask {
}
void checkMatchingPatchParameters(FunctionElement origin,
- Link<Element> originParameters,
- Link<Element> patchParameters) {
- while (!originParameters.isEmpty) {
- ParameterElementX originParameter = originParameters.head;
- ParameterElementX patchParameter = patchParameters.head;
+ List<Element> originParameters,
+ List<Element> patchParameters) {
+
+ assert(originParameters.length == patchParameters.length);
+ for (int index = 0; index < originParameters.length; index++) {
+ ParameterElementX originParameter = originParameters[index];
+ ParameterElementX patchParameter = patchParameters[index];
// TODO(johnniwinther): Remove the conditional patching when we never
// resolve the same method twice.
if (!originParameter.isPatched) {
@@ -86,9 +88,6 @@ class PatchResolverTask extends CompilerTask {
{'parameterName': patchParameter.name});
}
}
-
- originParameters = originParameters.tail;
- patchParameters = patchParameters.tail;
}
}
« no previous file with comments | « pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart ('k') | pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698